Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make read_date optional #117

Merged
merged 2 commits into from
Sep 11, 2022
Merged

Make read_date optional #117

merged 2 commits into from
Sep 11, 2022

Conversation

Antoni-Czaplicki
Copy link
Contributor

No description provided.

Copy link

@heyngra heyngra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm pretty sure you need to move the read_date under attachments (locally it fixes the issue below)
ValueError: No mandatory attributes allowed after an attribute with a default value or factory. Attribute in question: Attribute(name='status', default=NOTHING, validator=<instance_of validator for type <class 'int'>>, repr=True, eq=True, eq_key=None, order=True, order_key=None, hash=None, init=True, metadata=mappingproxy({'key': 'Status'}), type=<class 'int'>, converter=<function int_if_not_none at 0x0000022171003A30>, kw_only=False, inherited=False, on_setattr=None)

@Antoni-Czaplicki
Copy link
Contributor Author

I'm pretty sure you need to move the read_date under attachments
Thx, I forgot about this

@kuba2k2 kuba2k2 added the hotfix label Sep 11, 2022
@kuba2k2 kuba2k2 merged commit faeb5bc into kapi2289:master Sep 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants